mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-30 21:48:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

bpo-33203: Ensure random.choice always raises IndexError on empty sequence (GH-6338)

Browse source
This commit is contained in:
Wolfgang Maier 2018-04-05 17:19:44 +02:00 • committed by Raymond Hettinger
parent 74940913d2
commit 091e95e900
3 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Lib/test/test_random.py
View file

@ -651,7 +651,10 @@ class MersenneTwister_TestBasicOps(TestBasicOps, unittest.TestCase):
# Population range too large (n >= maxsize)
self.gen._randbelow(maxsize+1, maxsize = maxsize)
self.gen._randbelow(5640, maxsize = maxsize)
# issue 33203: test that _randbelow raises ValueError on
# n == 0 also in its getrandbits-independent branch.
with self.assertRaises(ValueError):
self.gen._randbelow(0, maxsize=maxsize)
# This might be going too far to test a single line, but because of our
# noble aim of achieving 100% test coverage we need to write a case in
# which the following line in Random._randbelow() gets executed: