bpo-43660: Fix crash when displaying exceptions with custom values for sys.stderr (GH-25075)

This commit is contained in:
Pablo Galindo 2021-03-29 23:38:51 +01:00 committed by GitHub
parent c8b5738810
commit 09b90a037d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 20 additions and 1 deletions

View file

@ -1512,6 +1512,21 @@ class SizeofTest(unittest.TestCase):
self.assertIsNone(cur.firstiter)
self.assertIsNone(cur.finalizer)
def test_changing_sys_stderr_and_removing_reference(self):
# If the default displayhook doesn't take a strong reference
# to sys.stderr the following code can crash. See bpo-43660
# for more details.
code = textwrap.dedent('''
import sys
class MyStderr:
def write(self, s):
sys.stderr = None
sys.stderr = MyStderr()
1/0
''')
rc, out, err = assert_python_failure('-c', code)
self.assertEqual(out, b"")
self.assertEqual(err, b"")
if __name__ == "__main__":
unittest.main()