mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-03 16:39:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

unpack_string(): avoid a compiler warning (about a real bug!) by

Browse source 
copying the result of fgetc() into an int variable before testing it
for EOF.
This commit is contained in:
Guido van Rossum 2002-07-20 00:38:01 +00:00
parent 65692578b7
commit 0b624f69b5
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Modules/_hotshot.c
View file

@ -305,6 +305,7 @@ unpack_string(LogReaderObject *self, PyObject **pvalue)
int i;
int len;
int err;
int ch;
char *buf;
if ((err = unpack_packed_int(self, &len, 0)))
@ -312,7 +313,9 @@ unpack_string(LogReaderObject *self, PyObject **pvalue)
buf = malloc(len);
for (i=0; i < len; i++) {
if ((buf[i] = fgetc(self->logfp)) == EOF) {
ch = fgetc(self->logfp);
buf[i] = ch;
if (ch == EOF) {
free(buf);
return ERR_EOF;
}