mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-03 08:34:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Jack Jansen hit a bug in the new dict code, reported on python-dev.

Browse source 
dictresize() was too aggressive about never ever resizing small dicts.
If a small dict is entirely full, it needs to rebuild it despite that
it won't actually resize it, in order to purge old dummy entries thus
creating at least one virgin slot (lookdict assumes at least one such
exists).

Also took the opportunity to add some high-level comments to dictresize.
This commit is contained in:
Tim Peters 2001-05-23 23:33:57 +00:00
parent a5ca7dd71a
commit 0c6010be75
2 changed files with 43 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Lib/test/test_operations.py
View file

@ -26,3 +26,18 @@ x2 = BadDictKey()
d[x1] = 1
d[x2] = 2
print "No exception passed through."
# Dict resizing bug, found by Jack Jansen in 2.2 CVS development.
# This version got an assert failure in debug build, infinite loop in
# release build. Unfortunately, provoking this kind of stuff requires
# a mix of inserts and deletes hitting exactly the right hash codes in
# exactly the right order, and I can't think of a randomized approach
# that would be *likely* to hit a failing case in reasonable time.
d = {}
for i in range(5):
d[i] = i
for i in range(5):
del d[i]
for i in range(5, 9): # i==8 was the problem
d[i] = i