mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-09 16:34:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 17

bpo-44326: Remove unused members from pysqlite_Statement (GH-26564)

Browse source 
* Remove unused db member of pysqlite_Statement

* Remove unused sql method from statement object
This commit is contained in:
Erlend Egeberg Aasland 2021-06-07 00:12:07 +02:00 • committed by GitHub
parent 505624e917
commit 0d12f24552
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Modules/_sqlite/statement.c
View file

@ -84,9 +84,7 @@ pysqlite_statement_create(pysqlite_Connection *connection, PyObject *sql)
return NULL;
}
self->db = connection->db;
self->st = NULL;
self->sql = Py_NewRef(sql);
self->in_use = 0;
self->is_dml = 0;
self->in_weakreflist = NULL;
@ -110,7 +108,7 @@ pysqlite_statement_create(pysqlite_Connection *connection, PyObject *sql)
}
Py_BEGIN_ALLOW_THREADS
rc = sqlite3_prepare_v2(self->db,
rc = sqlite3_prepare_v2(connection->db,
sql_cstr,
(int)sql_cstr_len + 1,
&self->st,
@ -120,7 +118,7 @@ pysqlite_statement_create(pysqlite_Connection *connection, PyObject *sql)
PyObject_GC_Track(self);
if (rc != SQLITE_OK) {
_pysqlite_seterror(self->db);
_pysqlite_seterror(connection->db);
goto error;
}
@ -409,23 +407,14 @@ stmt_dealloc(pysqlite_Statement *self)
Py_END_ALLOW_THREADS
self->st = 0;
}
tp->tp_clear((PyObject *)self);
tp->tp_free(self);
Py_DECREF(tp);
}
static int
stmt_clear(pysqlite_Statement *self)
{
Py_CLEAR(self->sql);
return 0;
}
static int
stmt_traverse(pysqlite_Statement *self, visitproc visit, void *arg)
{
Py_VISIT(Py_TYPE(self));
Py_VISIT(self->sql);
return 0;
}
@ -507,7 +496,6 @@ static PyType_Slot stmt_slots[] = {
{Py_tp_members, stmt_members},
{Py_tp_dealloc, stmt_dealloc},
{Py_tp_traverse, stmt_traverse},
{Py_tp_clear, stmt_clear},
{0, NULL},
};