mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-12-23 09:19:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Pull a NULL pointer check up to cover more cases in the function.

Browse source 
Found using Clang's static analyzer.
This commit is contained in:
Brett Cannon 2010-05-04 01:23:36 +00:00
parent a7f13ee3f5
commit 0d8a859a85
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Objects/abstract.c
View file

@ -1833,11 +1833,13 @@ PyNumber_ToBase(PyObject *n, int base)
int int
PySequence_Check(PyObject *s) PySequence_Check(PyObject *s)
{ {
if (s && PyInstance_Check(s)) if (s == NULL)
return 0;
if (PyInstance_Check(s))
return PyObject_HasAttrString(s, "__getitem__"); return PyObject_HasAttrString(s, "__getitem__");
if (PyDict_Check(s)) if (PyDict_Check(s))
return 0; return 0;
return s != NULL && s->ob_type->tp_as_sequence && return s->ob_type->tp_as_sequence &&
s->ob_type->tp_as_sequence->sq_item != NULL; s->ob_type->tp_as_sequence->sq_item != NULL;
} }