mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-14 18:59:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

gh-112625: Protect bytearray from being freed by misbehaving iterator inside bytearray.join (GH-112626)

Browse source
This commit is contained in:
chilaxan 2023-12-04 03:15:43 -05:00 • committed by GitHub
parent 23e001fa9f
commit 0e732d0997
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 22 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Lib/test/test_builtin.py
View file

@ -2039,6 +2039,23 @@ class BuiltinTest(unittest.TestCase):
bad_iter = map(int, "X")
self.assertRaises(ValueError, array.extend, bad_iter)
def test_bytearray_join_with_misbehaving_iterator(self):
# Issue #112625
array = bytearray(b',')
def iterator():
array.clear()
yield b'A'
yield b'B'
self.assertRaises(BufferError, array.join, iterator())
def test_bytearray_join_with_custom_iterator(self):
# Issue #112625
array = bytearray(b',')
def iterator():
yield b'A'
yield b'B'
self.assertEqual(bytearray(b'A,B'), array.join(iterator()))
def test_construct_singletons(self):
for const in None, Ellipsis, NotImplemented:
tp = type(const)