mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-25 04:34:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

bpo-29602: fix signed zero handling in complex constructor. (#203)

Browse source 
* Fix incorrect handling of signed zeros for complex-related classes.

* Add Misc/NEWS entry.
This commit is contained in:
Mark Dickinson 2017-02-20 20:28:15 +00:00 • committed by GitHub
parent 1b8df107f8
commit 112ec38c15
3 changed files with 30 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Objects/complexobject.c
View file

@ -1025,11 +1025,11 @@ complex_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
return NULL;
}
cr.real = PyFloat_AsDouble(tmp);
cr.imag = 0.0; /* Shut up compiler warning */
cr.imag = 0.0;
Py_DECREF(tmp);
}
if (i == NULL) {
ci.real = 0.0;
ci.real = cr.imag;
}
else if (PyComplex_Check(i)) {
ci = ((PyComplexObject*)i)->cval;
@ -1051,7 +1051,7 @@ complex_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
if (ci_is_complex) {
cr.real -= ci.imag;
}
if (cr_is_complex) {
if (cr_is_complex && i != NULL) {
ci.real += cr.imag;
}
return complex_subtype_from_doubles(type, cr.real, ci.real);