gh-121040: Use __attribute__((fallthrough)) (#121044)

Fix warnings when using -Wimplicit-fallthrough compiler flag.

Annotate explicitly "fall through" switch cases with a new
_Py_FALLTHROUGH macro which uses __attribute__((fallthrough)) if
available. Replace "fall through" comments with _Py_FALLTHROUGH.

Add _Py__has_attribute() macro. No longer define __has_attribute()
macro if it's not defined. Move also _Py__has_builtin() at the top
of pyport.h.

Co-Authored-By: Nikita Sobolev <mail@sobolevn.me>
This commit is contained in:
Victor Stinner 2024-06-27 11:58:44 +02:00 committed by GitHub
parent 4999e0bda0
commit 12af8ec864
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
29 changed files with 131 additions and 104 deletions

View file

@ -1234,7 +1234,7 @@ char * PyOS_double_to_string(double val,
case 'E':
float_strings = uc_float_strings;
format_code = 'e';
/* Fall through. */
_Py_FALLTHROUGH;
case 'e':
mode = 2;
precision++;
@ -1244,7 +1244,7 @@ char * PyOS_double_to_string(double val,
case 'F':
float_strings = uc_float_strings;
format_code = 'f';
/* Fall through. */
_Py_FALLTHROUGH;
case 'f':
mode = 3;
break;
@ -1253,7 +1253,7 @@ char * PyOS_double_to_string(double val,
case 'G':
float_strings = uc_float_strings;
format_code = 'g';
/* Fall through. */
_Py_FALLTHROUGH;
case 'g':
mode = 2;
/* precision 0 makes no sense for 'g' format; interpret as 1 */