mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-02 16:13:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

bpo-33761: Fix a file leak in test_iterparse in test_xml_etree. (GH-7358)

Browse source
This commit is contained in:
Serhiy Storchaka 2018-06-03 20:56:52 +03:00 • committed by GitHub
parent e95dfc5006
commit 13f51d9eec
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Lib/test/test_xml_etree.py
View file

@ -617,6 +617,7 @@ class ElementTreeTest(unittest.TestCase):
self.assertEqual(str(cm.exception), self.assertEqual(str(cm.exception),
'junk after document element: line 1, column 12') 'junk after document element: line 1, column 12')
self.addCleanup(support.unlink, TESTFN)
with open(TESTFN, "wb") as f: with open(TESTFN, "wb") as f:
f.write(b"<document />junk") f.write(b"<document />junk")
it = iterparse(TESTFN) it = iterparse(TESTFN)
@ -2849,9 +2850,6 @@ class ElementSlicingTest(unittest.TestCase):
class IOTest(unittest.TestCase): class IOTest(unittest.TestCase):
def tearDown(self):
support.unlink(TESTFN)
def test_encoding(self): def test_encoding(self):
# Test encoding issues. # Test encoding issues.
elem = ET.Element("tag") elem = ET.Element("tag")
@ -2922,12 +2920,14 @@ class IOTest(unittest.TestCase):
"<tag key=\"åöö&lt;&gt;\" />" % enc).encode(enc)) "<tag key=\"åöö&lt;&gt;\" />" % enc).encode(enc))
def test_write_to_filename(self): def test_write_to_filename(self):
self.addCleanup(support.unlink, TESTFN)
tree = ET.ElementTree(ET.XML('''<site />''')) tree = ET.ElementTree(ET.XML('''<site />'''))
tree.write(TESTFN) tree.write(TESTFN)
with open(TESTFN, 'rb') as f: with open(TESTFN, 'rb') as f:
self.assertEqual(f.read(), b'''<site />''') self.assertEqual(f.read(), b'''<site />''')
def test_write_to_text_file(self): def test_write_to_text_file(self):
self.addCleanup(support.unlink, TESTFN)
tree = ET.ElementTree(ET.XML('''<site />''')) tree = ET.ElementTree(ET.XML('''<site />'''))
with open(TESTFN, 'w', encoding='utf-8') as f: with open(TESTFN, 'w', encoding='utf-8') as f:
tree.write(f, encoding='unicode') tree.write(f, encoding='unicode')
@ -2936,6 +2936,7 @@ class IOTest(unittest.TestCase):
self.assertEqual(f.read(), b'''<site />''') self.assertEqual(f.read(), b'''<site />''')
def test_write_to_binary_file(self): def test_write_to_binary_file(self):
self.addCleanup(support.unlink, TESTFN)
tree = ET.ElementTree(ET.XML('''<site />''')) tree = ET.ElementTree(ET.XML('''<site />'''))
with open(TESTFN, 'wb') as f: with open(TESTFN, 'wb') as f:
tree.write(f) tree.write(f)
@ -2944,6 +2945,7 @@ class IOTest(unittest.TestCase):
self.assertEqual(f.read(), b'''<site />''') self.assertEqual(f.read(), b'''<site />''')
def test_write_to_binary_file_with_bom(self): def test_write_to_binary_file_with_bom(self):
self.addCleanup(support.unlink, TESTFN)
tree = ET.ElementTree(ET.XML('''<site />''')) tree = ET.ElementTree(ET.XML('''<site />'''))
# test BOM writing to buffered file # test BOM writing to buffered file
with open(TESTFN, 'wb') as f: with open(TESTFN, 'wb') as f: