mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 08:59:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

bpo-31250, test_asyncio: fix dangling threads (#3252)

Browse source 
* Explicitly call shutdown(wait=True) on executors to wait until all
  threads complete to prevent side effects between tests.
* Fix test_loop_self_reading_exception(): don't mock loop.close().
  Previously, the original close() method was called rather than the
  mock, because how set_event_loop() registered loop.close().
This commit is contained in:
Victor Stinner 2017-09-01 14:46:06 +02:00 • committed by GitHub
parent 6c2feabc5d
commit 16432beadb
3 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Lib/test/test_asyncio/test_futures.py
View file

@ -380,6 +380,7 @@ class BaseFutureTests:
self.assertTrue(asyncio.isfuture(f2))
self.assertEqual(res, 'oi')
self.assertNotEqual(ident, threading.get_ident())
ex.shutdown(wait=True)
def test_wrap_future_future(self):
f1 = self._new_future(loop=self.loop)
@ -395,6 +396,7 @@ class BaseFutureTests:
f1 = ex.submit(run, 'oi')
f2 = asyncio.wrap_future(f1)
self.assertIs(self.loop, f2._loop)
ex.shutdown(wait=True)
def test_wrap_future_cancel(self):
f1 = concurrent.futures.Future()