gh-136523: Fix wave.Wave_write emitting an unraisable when open raises (GH-136529)

This commit is contained in:
Sachin Shah 2025-07-13 01:49:12 -04:00 committed by GitHub
parent 42b251bceb
commit 171de05b48
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 12 additions and 0 deletions

View file

@ -2,6 +2,7 @@ import unittest
from test import audiotests
from test import support
import io
import os
import struct
import sys
import wave
@ -196,6 +197,14 @@ class WaveLowLevelTest(unittest.TestCase):
with self.assertRaisesRegex(wave.Error, 'bad sample width'):
wave.open(io.BytesIO(b))
def test_open_in_write_raises(self):
# gh-136523: Wave_write.__del__ should not throw
with support.catch_unraisable_exception() as cm:
with self.assertRaises(OSError):
wave.open(os.curdir, "wb")
support.gc_collect()
self.assertIsNone(cm.unraisable)
if __name__ == '__main__':
unittest.main()

View file

@ -427,6 +427,8 @@ class Wave_write:
_datawritten -- the size of the audio samples actually written
"""
_file = None
def __init__(self, f):
self._i_opened_the_file = None
if isinstance(f, str):

View file

@ -0,0 +1 @@
Fix :class:`wave.Wave_write` emitting an unraisable when open raises.