Style guide & consistency changes. No semantic changes.

This commit is contained in:
Tim Peters 2004-10-09 17:38:29 +00:00
parent 4c1f5ecfe3
commit 19717fa33a
2 changed files with 41 additions and 29 deletions

View file

@ -388,18 +388,20 @@ static int autoTLSkey = 0;
/* Internal initialization/finalization functions called by /* Internal initialization/finalization functions called by
Py_Initialize/Py_Finalize Py_Initialize/Py_Finalize
*/ */
void _PyGILState_Init(PyInterpreterState *i, PyThreadState *t) void
_PyGILState_Init(PyInterpreterState *i, PyThreadState *t)
{ {
assert(i && t); /* must init with a valid states */ assert(i && t); /* must init with valid states */
autoTLSkey = PyThread_create_key(); autoTLSkey = PyThread_create_key();
autoInterpreterState = i; autoInterpreterState = i;
/* Now stash the thread state for this thread in TLS */ /* Now stash the thread state for this thread in TLS */
PyThread_set_key_value(autoTLSkey, (void *)t); PyThread_set_key_value(autoTLSkey, (void *)t);
assert(t->gilstate_counter==0); /* must be a new thread state */ assert(t->gilstate_counter == 0); /* must be a new thread state */
t->gilstate_counter = 1; t->gilstate_counter = 1;
} }
void _PyGILState_Fini(void) void
_PyGILState_Fini(void)
{ {
PyThread_delete_key(autoTLSkey); PyThread_delete_key(autoTLSkey);
autoTLSkey = 0; autoTLSkey = 0;
@ -407,14 +409,16 @@ void _PyGILState_Fini(void)
} }
/* The public functions */ /* The public functions */
PyThreadState *PyGILState_GetThisThreadState(void) PyThreadState *
PyGILState_GetThisThreadState(void)
{ {
if (autoInterpreterState==NULL || autoTLSkey==0) if (autoInterpreterState == NULL || autoTLSkey == 0)
return NULL; return NULL;
return (PyThreadState *) PyThread_get_key_value(autoTLSkey); return (PyThreadState *)PyThread_get_key_value(autoTLSkey);
} }
PyGILState_STATE PyGILState_Ensure(void) PyGILState_STATE
PyGILState_Ensure(void)
{ {
int current; int current;
PyThreadState *tcur; PyThreadState *tcur;
@ -425,30 +429,32 @@ PyGILState_STATE PyGILState_Ensure(void)
*/ */
assert(autoInterpreterState); /* Py_Initialize() hasn't been called! */ assert(autoInterpreterState); /* Py_Initialize() hasn't been called! */
tcur = PyThread_get_key_value(autoTLSkey); tcur = PyThread_get_key_value(autoTLSkey);
if (tcur==NULL) { if (tcur == NULL) {
/* Create a new thread state for this thread */ /* Create a new thread state for this thread */
tcur = PyThreadState_New(autoInterpreterState); tcur = PyThreadState_New(autoInterpreterState);
if (tcur==NULL) if (tcur == NULL)
Py_FatalError("Couldn't create thread-state for new thread"); Py_FatalError("Couldn't create thread-state for new thread");
PyThread_set_key_value(autoTLSkey, (void *)tcur); PyThread_set_key_value(autoTLSkey, (void *)tcur);
current = 0; /* new thread state is never current */ current = 0; /* new thread state is never current */
} else }
else
current = PyThreadState_IsCurrent(tcur); current = PyThreadState_IsCurrent(tcur);
if (!current) if (current == 0)
PyEval_RestoreThread(tcur); PyEval_RestoreThread(tcur);
/* Update our counter in the thread-state - no need for locks: /* Update our counter in the thread-state - no need for locks:
- tcur will remain valid as we hold the GIL. - tcur will remain valid as we hold the GIL.
- the counter is safe as we are the only thread "allowed" - the counter is safe as we are the only thread "allowed"
to modify this value to modify this value
*/ */
tcur->gilstate_counter++; ++tcur->gilstate_counter;
return current ? PyGILState_LOCKED : PyGILState_UNLOCKED; return current ? PyGILState_LOCKED : PyGILState_UNLOCKED;
} }
void PyGILState_Release(PyGILState_STATE oldstate) void
PyGILState_Release(PyGILState_STATE oldstate)
{ {
PyThreadState *tcur = PyThread_get_key_value(autoTLSkey); PyThreadState *tcur = PyThread_get_key_value(autoTLSkey);
if (tcur==NULL) if (tcur == NULL)
Py_FatalError("auto-releasing thread-state, " Py_FatalError("auto-releasing thread-state, "
"but no thread-state for this thread"); "but no thread-state for this thread");
/* We must hold the GIL and have our thread state current */ /* We must hold the GIL and have our thread state current */
@ -456,27 +462,27 @@ void PyGILState_Release(PyGILState_STATE oldstate)
but while this is very new (April 2003), the extra check but while this is very new (April 2003), the extra check
by release-only users can't hurt. by release-only users can't hurt.
*/ */
if (!PyThreadState_IsCurrent(tcur)) if (! PyThreadState_IsCurrent(tcur))
Py_FatalError("This thread state must be current when releasing"); Py_FatalError("This thread state must be current when releasing");
assert (PyThreadState_IsCurrent(tcur)); assert(PyThreadState_IsCurrent(tcur));
tcur->gilstate_counter -= 1; --tcur->gilstate_counter;
assert (tcur->gilstate_counter >= 0); /* illegal counter value */ assert(tcur->gilstate_counter >= 0); /* illegal counter value */
/* If we are about to destroy this thread-state, we must /* If we are about to destroy this thread-state, we must
clear it while the lock is held, as destructors may run clear it while the lock is held, as destructors may run
*/ */
if (tcur->gilstate_counter==0) { if (tcur->gilstate_counter == 0) {
/* can't have been locked when we created it */ /* can't have been locked when we created it */
assert(oldstate==PyGILState_UNLOCKED); assert(oldstate == PyGILState_UNLOCKED);
PyThreadState_Clear(tcur); PyThreadState_Clear(tcur);
} }
/* Release the lock if necessary */ /* Release the lock if necessary */
if (oldstate==PyGILState_UNLOCKED) if (oldstate == PyGILState_UNLOCKED)
PyEval_ReleaseThread(tcur); PyEval_ReleaseThread(tcur);
/* Now complete destruction of the thread if necessary */ /* Now complete destruction of the thread if necessary */
if (tcur->gilstate_counter==0) { if (tcur->gilstate_counter == 0) {
/* Delete this thread from our TLS */ /* Delete this thread from our TLS */
PyThread_delete_key_value(autoTLSkey); PyThread_delete_key_value(autoTLSkey);
/* Delete the thread-state */ /* Delete the thread-state */

View file

@ -157,7 +157,8 @@ static struct key *keyhead = NULL;
static int nkeys = 0; static int nkeys = 0;
static PyThread_type_lock keymutex = NULL; static PyThread_type_lock keymutex = NULL;
static struct key *find_key(int key, void *value) static struct key *
find_key(int key, void *value)
{ {
struct key *p; struct key *p;
long id = PyThread_get_thread_ident(); long id = PyThread_get_thread_ident();
@ -180,14 +181,16 @@ static struct key *find_key(int key, void *value)
return p; return p;
} }
int PyThread_create_key(void) int
PyThread_create_key(void)
{ {
if (keymutex == NULL) if (keymutex == NULL)
keymutex = PyThread_allocate_lock(); keymutex = PyThread_allocate_lock();
return ++nkeys; return ++nkeys;
} }
void PyThread_delete_key(int key) void
PyThread_delete_key(int key)
{ {
struct key *p, **q; struct key *p, **q;
PyThread_acquire_lock(keymutex, 1); PyThread_acquire_lock(keymutex, 1);
@ -204,7 +207,8 @@ void PyThread_delete_key(int key)
PyThread_release_lock(keymutex); PyThread_release_lock(keymutex);
} }
int PyThread_set_key_value(int key, void *value) int
PyThread_set_key_value(int key, void *value)
{ {
struct key *p = find_key(key, value); struct key *p = find_key(key, value);
if (p == NULL) if (p == NULL)
@ -213,7 +217,8 @@ int PyThread_set_key_value(int key, void *value)
return 0; return 0;
} }
void *PyThread_get_key_value(int key) void *
PyThread_get_key_value(int key)
{ {
struct key *p = find_key(key, NULL); struct key *p = find_key(key, NULL);
if (p == NULL) if (p == NULL)
@ -222,7 +227,8 @@ void *PyThread_get_key_value(int key)
return p->value; return p->value;
} }
void PyThread_delete_key_value(int key) void
PyThread_delete_key_value(int key)
{ {
long id = PyThread_get_thread_ident(); long id = PyThread_get_thread_ident();
struct key *p, **q; struct key *p, **q;