mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-06 23:21:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

bpo-45052: Unskips a failing test_shared_memory_basics test (GH-28182)

Browse source
This commit is contained in:
Nikita Sobolev 2021-09-06 19:55:34 +03:00 • committed by GitHub
parent 37272f5800
commit 19871fce3b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Lib/test/_test_multiprocessing.py
View file

@ -3773,7 +3773,6 @@ class _TestSharedMemory(BaseTestCase):
local_sms.buf[:len(binary_data)] = binary_data local_sms.buf[:len(binary_data)] = binary_data
local_sms.close() local_sms.close()
@unittest.skipIf(sys.platform == "win32", "test is broken on Windows")
def test_shared_memory_basics(self): def test_shared_memory_basics(self):
sms = shared_memory.SharedMemory('test01_tsmb', create=True, size=512) sms = shared_memory.SharedMemory('test01_tsmb', create=True, size=512)
self.addCleanup(sms.unlink) self.addCleanup(sms.unlink)
@ -3792,7 +3791,6 @@ class _TestSharedMemory(BaseTestCase):
pickled_sms = pickle.dumps(sms) pickled_sms = pickle.dumps(sms)
sms2 = pickle.loads(pickled_sms) sms2 = pickle.loads(pickled_sms)
self.assertEqual(sms.name, sms2.name) self.assertEqual(sms.name, sms2.name)
self.assertEqual(sms.size, sms2.size)
self.assertEqual(bytes(sms.buf[0:6]), bytes(sms2.buf[0:6]), b'pickle') self.assertEqual(bytes(sms.buf[0:6]), bytes(sms2.buf[0:6]), b'pickle')
# Modify contents of shared memory segment through memoryview. # Modify contents of shared memory segment through memoryview.

7
Misc/NEWS.d/next/Tests/2021-09-06-19-00-29.bpo-45052.yrOK3J.rst Normal file
View file

@ -0,0 +1,7 @@
``WithProcessesTestSharedMemory.test_shared_memory_basics`` test was
ignored, because ``self.assertEqual(sms.size, sms2.size)`` line was failing.
It is now removed and test is unskipped.
The main motivation for this line to be removed from the test is that the
``size`` of ``SharedMemory`` is not ever guaranteed to be the same. It is
decided by the platform.