bpo-32411: IDLE: Remove line number sort in browser.py (#5011)

Insertion in line order makes sorting keys by line order unneeded.
This commit is contained in:
Cheryl Sabella 2019-06-01 17:03:22 -04:00 committed by Terry Jan Reedy
parent e5f6207ba6
commit 1a4d9ffa1a
4 changed files with 22 additions and 17 deletions

View file

@ -29,9 +29,10 @@ def transform_children(child_dict, modname=None):
The dictionary maps names to pyclbr information objects.
Filter out imported objects.
Augment class names with bases.
Sort objects by line number.
The insertion order of the dictonary is assumed to have been in line
number order, so sorting is not necessary.
The current tree only calls this once per child_dic as it saves
The current tree only calls this once per child_dict as it saves
TreeItems once created. A future tree and tests might violate this,
so a check prevents multiple in-place augmentations.
"""
@ -51,7 +52,7 @@ def transform_children(child_dict, modname=None):
supers.append(sname)
obj.name += '({})'.format(', '.join(supers))
obs.append(obj)
return sorted(obs, key=lambda o: o.lineno)
return obs
class ModuleBrowser: