mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-31 14:07:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

#2683: Popen.communicate() argument must be bytes.

Browse source
This commit is contained in:
Georg Brandl 2008-07-01 19:28:43 +00:00
parent c22ed14ddd
commit 1abcbf8e19
3 changed files with 5 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Lib/subprocess.py
View file

@ -883,8 +883,6 @@ class Popen(object):
if self.stdin:
if input is not None:
if isinstance(input, str):
input = input.encode()
self.stdin.write(input)
self.stdin.close()
@ -1129,10 +1127,6 @@ class Popen(object):
def _communicate(self, input):
if self.stdin:
if isinstance(input, str): # Unicode
input = input.encode("utf-8") # XXX What else?
input = bytes(input)
read_set = []
write_set = []
stdout = None # Return