mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-03 03:22:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

gh-117649: Fix file descriptor leak in (expected) failing test case (#117780)

Browse source 
The test case is currently expected to fail in the free-threaded build.
However, it fails before it gets a chance to close the write end of
the pipe.
This commit is contained in:
Sam Gross 2024-04-11 17:35:46 -04:00 • committed by GitHub
parent 25f6ff5d3e
commit 1b10efad66
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Lib/test/test_capi/test_misc.py
View file

@ -2139,6 +2139,9 @@ class SubinterpreterTest(unittest.TestCase):
} }
r, w = os.pipe() r, w = os.pipe()
if Py_GIL_DISABLED:
# gh-117649: The test fails before `w` is closed
self.addCleanup(os.close, w)
script = textwrap.dedent(f''' script = textwrap.dedent(f'''
from test.test_capi.check_config import run_singlephase_check from test.test_capi.check_config import run_singlephase_check
run_singlephase_check({override}, {w}) run_singlephase_check({override}, {w})