mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-12-04 16:43:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

gh-109795: _thread.start_new_thread: allocate thread bootstate using raw memory allocator (#109808)

Browse source
This commit is contained in:
Radislav Chugunov 2023-09-25 18:38:06 +03:00 • committed by GitHub
parent f19416534a
commit 1b8f2366b3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Modules/_threadmodule.c
View file

@ -1066,7 +1066,7 @@ thread_bootstate_free(struct bootstate *boot, int decref)
Py_DECREF(boot->args); Py_DECREF(boot->args);
Py_XDECREF(boot->kwargs); Py_XDECREF(boot->kwargs);
} }
PyMem_Free(boot); PyMem_RawFree(boot);
} }
@ -1184,13 +1184,16 @@ thread_PyThread_start_new_thread(PyObject *self, PyObject *fargs)
return NULL; return NULL;
} }
struct bootstate *boot = PyMem_NEW(struct bootstate, 1); // gh-109795: Use PyMem_RawMalloc() instead of PyMem_Malloc(),
// because it should be possible to call thread_bootstate_free()
// without holding the GIL.
struct bootstate *boot = PyMem_RawMalloc(sizeof(struct bootstate));
if (boot == NULL) { if (boot == NULL) {
return PyErr_NoMemory(); return PyErr_NoMemory();
} }
boot->tstate = _PyThreadState_New(interp); boot->tstate = _PyThreadState_New(interp);
if (boot->tstate == NULL) { if (boot->tstate == NULL) {
PyMem_Free(boot); PyMem_RawFree(boot);
if (!PyErr_Occurred()) { if (!PyErr_Occurred()) {
return PyErr_NoMemory(); return PyErr_NoMemory();
} }