Issue #11386: Fixed the exception thrown by bytearray.pop() for empty bytearrays

Lib/test/test_bytes.py

@@ -790,7 +790,7 @@ class ByteArrayTest(BaseBytesTest):
         self.assertEqual(b.pop(0), ord('w'))
         self.assertEqual(b.pop(-2), ord('r'))
         self.assertRaises(IndexError, lambda: b.pop(10))
-        self.assertRaises(OverflowError, lambda: bytearray().pop())
+        self.assertRaises(IndexError, lambda: bytearray().pop())
         # test for issue #6846
         self.assertEqual(bytearray(b'\xff').pop(), 0xff)
 

Misc/NEWS

@@ -49,6 +49,9 @@ Core and Builtins
 
 - Issue #10516: New copy() and clear() methods for lists and bytearrays.
 
+- Issue #11386: bytearray.pop() now throws IndexError when the bytearray is
+  empty, instead of OverflowError.
+
 Library
 -------
 

Objects/bytearrayobject.c

@@ -2309,8 +2309,8 @@ bytearray_pop(PyByteArrayObject *self, PyObject *args)
         return NULL;
 
     if (n == 0) {
-        PyErr_SetString(PyExc_OverflowError,
+        PyErr_SetString(PyExc_IndexError,
-                        "cannot pop an empty bytearray");
+                        "pop from empty bytearray");
         return NULL;
     }
     if (where < 0)