Issue #1869: Fix a couple of minor round() issues.

This commit is contained in:
Mark Dickinson 2009-04-18 14:59:42 +00:00
parent 8e5446f902
commit 1bdf7e9cab
3 changed files with 7 additions and 4 deletions

View file

@ -1224,6 +1224,9 @@ class BuiltinTest(unittest.TestCase):
self.assertEqual(round(-5.5), -6)
self.assertEqual(round(-6.5), -7)
# Issue #1869: integral floats should remain unchanged
self.assertEqual(round(5e15+1), 5e15+1)
# Check behavior on ints
self.assertEqual(round(0), 0)
self.assertEqual(round(8), 8)

View file

@ -12,6 +12,9 @@ What's New in Python 2.7 alpha 1
Core and Builtins
-----------------
- Issue #1869: fix a couple of minor round() issues. round(5e15+1)
was giving 5e15+2; round(-0.0) was losing the sign of the zero.
- Issue #5759: float() didn't call __float__ on str subclasses.
- Issue #5704: the "-3" command-line option now implies "-t".

View file

@ -2081,10 +2081,7 @@ builtin_round(PyObject *self, PyObject *args, PyObject *kwds)
number /= f;
else
number *= f;
if (number >= 0.0)
number = floor(number + 0.5);
else
number = ceil(number - 0.5);
number = round(number);
if (ndigits < 0)
number *= f;
else