Fixes Issue #15798 - subprocess.Popen() no longer fails if file

descriptor 0, 1 or 2 is closed.
This commit is contained in:
Gregory P. Smith 2013-11-30 19:04:00 -08:00
commit 1c27e3c7fb
4 changed files with 29 additions and 6 deletions

View file

@ -1361,7 +1361,10 @@ class Popen(object):
executable_list = tuple(
os.path.join(os.fsencode(dir), executable)
for dir in os.get_exec_path(env))
fds_to_keep = set(pass_fds)
# Never close stdin, stdout and stderr for the child.
fds_to_keep = {0,1,2}
fds_to_keep.update(pass_fds)
# Our child uses this one to signal error before exec().
fds_to_keep.add(errpipe_write)
self.pid = _posixsubprocess.fork_exec(
args, executable_list,