mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-31 14:07:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Fixes Issue #15798 - subprocess.Popen() no longer fails if file

Browse source 
descriptor 0, 1 or 2 is closed.
This commit is contained in:
Gregory P. Smith 2013-11-30 19:04:00 -08:00
commit 1c27e3c7fb
4 changed files with 29 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Modules/_posixsubprocess.c
View file

@ -458,7 +458,7 @@ child_exec(char *const exec_array[],
local_max_fd = max_fd;
#endif
/* TODO HP-UX could use pstat_getproc() if anyone cares about it. */
_close_open_fd_range(3, local_max_fd, py_fds_to_keep);
_close_open_fd_range(0, local_max_fd, py_fds_to_keep);
}
/* This loop matches the Lib/os.py _execvpe()'s PATH search when */
@ -535,10 +535,6 @@ subprocess_fork_exec(PyObject* self, PyObject *args)
&restore_signals, &call_setsid, &preexec_fn))
return NULL;
if (close_fds && errpipe_write < 3) { /* precondition */
PyErr_SetString(PyExc_ValueError, "errpipe_write must be >= 3");
return NULL;
}
if (PySequence_Length(py_fds_to_keep) < 0) {
PyErr_SetString(PyExc_ValueError, "cannot get length of fds_to_keep");
return NULL;