mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-09 16:34:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 17

bpo-46004: Fix error location for loops with invalid targets (GH-29959)

Browse source
This commit is contained in:
Pablo Galindo Salgado 2021-12-07 13:02:15 +00:00 • committed by GitHub
parent cf7eaa4617
commit 1c7a1c3be0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Lib/test/test_exceptions.py
View file

@ -234,6 +234,7 @@ class ExceptionTests(unittest.TestCase):
check("ages = {'Alice'=22, 'Bob'=23}", 1, 16) check("ages = {'Alice'=22, 'Bob'=23}", 1, 16)
check('match ...:\n case {**rest, "key": value}:\n ...', 2, 19) check('match ...:\n case {**rest, "key": value}:\n ...', 2, 19)
check("[a b c d e f]", 1, 2) check("[a b c d e f]", 1, 2)
check("for x yfff:", 1, 7)
# Errors thrown by compile.c # Errors thrown by compile.c
check('class foo:return 1', 1, 11) check('class foo:return 1', 1, 11)

2
Misc/NEWS.d/next/Core and Builtins/2021-12-07-11-24-24.bpo-46004.TTEU1p.rst Normal file
View file

@ -0,0 +1,2 @@
Fix the :exc:`SyntaxError` location for errors involving for loops with
invalid targets. Patch by Pablo Galindo

3
Parser/pegen.h
View file

@ -227,8 +227,9 @@ _RAISE_SYNTAX_ERROR_INVALID_TARGET(Parser *p, TARGETS_TYPE type, void *e)
msg, msg,
_PyPegen_get_expr_name(invalid_target) _PyPegen_get_expr_name(invalid_target)
); );
return RAISE_SYNTAX_ERROR_KNOWN_LOCATION(invalid_target, "invalid syntax");
} }
return RAISE_SYNTAX_ERROR("invalid syntax"); return NULL;
} }
// Action utility functions // Action utility functions