mirror of
https://github.com/python/cpython.git
synced 2025-08-22 09:45:06 +00:00
bpo-36801: Fix waiting in StreamWriter.drain for closing SSL transport (GH-13098)
https://bugs.python.org/issue36801
This commit is contained in:
parent
e19a91e45f
commit
1cc0ee7d9f
4 changed files with 46 additions and 8 deletions
|
@ -199,6 +199,9 @@ class FlowControlMixin(protocols.Protocol):
|
|||
self._drain_waiter = waiter
|
||||
await waiter
|
||||
|
||||
def _get_close_waiter(self, stream):
|
||||
raise NotImplementedError
|
||||
|
||||
|
||||
class StreamReaderProtocol(FlowControlMixin, protocols.Protocol):
|
||||
"""Helper class to adapt between Protocol and StreamReader.
|
||||
|
@ -315,6 +318,9 @@ class StreamReaderProtocol(FlowControlMixin, protocols.Protocol):
|
|||
return False
|
||||
return True
|
||||
|
||||
def _get_close_waiter(self, stream):
|
||||
return self._closed
|
||||
|
||||
def __del__(self):
|
||||
# Prevent reports about unhandled exceptions.
|
||||
# Better than self._closed._log_traceback = False hack
|
||||
|
@ -376,7 +382,7 @@ class StreamWriter:
|
|||
return self._transport.is_closing()
|
||||
|
||||
async def wait_closed(self):
|
||||
await self._protocol._closed
|
||||
await self._protocol._get_close_waiter(self)
|
||||
|
||||
def get_extra_info(self, name, default=None):
|
||||
return self._transport.get_extra_info(name, default)
|
||||
|
@ -394,13 +400,12 @@ class StreamWriter:
|
|||
if exc is not None:
|
||||
raise exc
|
||||
if self._transport.is_closing():
|
||||
# Yield to the event loop so connection_lost() may be
|
||||
# called. Without this, _drain_helper() would return
|
||||
# immediately, and code that calls
|
||||
# write(...); await drain()
|
||||
# in a loop would never call connection_lost(), so it
|
||||
# would not see an error when the socket is closed.
|
||||
await sleep(0, loop=self._loop)
|
||||
# Wait for protocol.connection_lost() call
|
||||
# Raise connection closing error if any,
|
||||
# ConnectionResetError otherwise
|
||||
fut = self._protocol._get_close_waiter(self)
|
||||
await fut
|
||||
raise ConnectionResetError('Connection lost')
|
||||
await self._protocol._drain_helper()
|
||||
|
||||
async def aclose(self):
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue