[3.6] bpo-28087: Skip test_asyncore and test_eintr poll failures on macOS (#463)

Skip some tests of select.poll when running on macOS due to unresolved
issues with the underlying system poll function on some macOS versions.

(cherry picked from commit de04644627)
This commit is contained in:
Ned Deily 2017-03-04 06:19:05 -05:00 committed by GitHub
parent 343d48379c
commit 1d391f926b
3 changed files with 9 additions and 0 deletions

View file

@ -437,6 +437,8 @@ class SelectEINTRTest(EINTRBaseTest):
self.stop_alarm() self.stop_alarm()
self.assertGreaterEqual(dt, self.sleep_time) self.assertGreaterEqual(dt, self.sleep_time)
@unittest.skipIf(sys.platform == "darwin",
"poll may fail on macOS; see issue #28087")
@unittest.skipUnless(hasattr(select, 'poll'), 'need select.poll') @unittest.skipUnless(hasattr(select, 'poll'), 'need select.poll')
def test_poll(self): def test_poll(self):
poller = select.poll() poller = select.poll()

View file

@ -661,6 +661,9 @@ class BaseTestAPI:
if HAS_UNIX_SOCKETS and self.family == socket.AF_UNIX: if HAS_UNIX_SOCKETS and self.family == socket.AF_UNIX:
self.skipTest("Not applicable to AF_UNIX sockets.") self.skipTest("Not applicable to AF_UNIX sockets.")
if sys.platform == "darwin" and self.use_poll:
self.skipTest("poll may fail on macOS; see issue #28087")
class TestClient(BaseClient): class TestClient(BaseClient):
def handle_expt(self): def handle_expt(self):
self.socket.recv(1024, socket.MSG_OOB) self.socket.recv(1024, socket.MSG_OOB)

View file

@ -261,6 +261,10 @@ Documentation
Tests Tests
----- -----
- bpo-28087: Skip test_asyncore and test_eintr poll failures on macOS.
Skip some tests of select.poll when running on macOS due to unresolved
issues with the underlying system poll function on some macOS versions.
- Issue #29571: to match the behaviour of the ``re.LOCALE`` flag, - Issue #29571: to match the behaviour of the ``re.LOCALE`` flag,
test_re.test_locale_flag now uses ``locale.getpreferredencoding(False)`` to test_re.test_locale_flag now uses ``locale.getpreferredencoding(False)`` to
determine the candidate encoding for the test regex (allowing it to correctly determine the candidate encoding for the test regex (allowing it to correctly