mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-07-23 11:15:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

GH-113528: Deoptimise pathlib._abc.PurePathBase.name (#113531)

Browse source 
Replace usage of `_from_parsed_parts()` with `with_segments()` in
`with_name()`, and take a similar approach in `name` for consistency's
sake.
This commit is contained in:
Barney Gale 2024-01-06 20:50:25 +00:00 • committed by GitHub
parent 2205510e7b
commit 1e914ad89d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 25 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Lib/pathlib/_abc.py
View file

@ -313,10 +313,10 @@ class PurePathBase:
@property
def name(self):
"""The final path component, if any."""
tail = self._tail
if not tail:
path_str = str(self)
if not path_str or path_str == '.':
return ''
return tail[-1]
return self.pathmod.basename(path_str)
@property
def suffix(self):
@ -360,11 +360,10 @@ class PurePathBase:
m = self.pathmod
if not name or m.sep in name or (m.altsep and m.altsep in name) or name == '.':
raise ValueError(f"Invalid name {name!r}")
tail = self._tail.copy()
if not tail:
parent, old_name = m.split(str(self))
if not old_name or old_name == '.':
raise ValueError(f"{self!r} has an empty name")
tail[-1] = name
return self._from_parsed_parts(self.drive, self.root, tail)
return self.with_segments(parent, name)
def with_stem(self, stem):
"""Return a new path with the stem changed."""