mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-02 08:02:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

#Issue3088 in-progress: Race condition with instances of classes derived from threading.local:

Browse source 
When a thread touches such an object for the first time, a new thread-local __dict__ is created,
and the __init__ method is run.
But a thread switch can occur here; if the other thread touches the same object, it installs another
__dict__; when the first thread resumes, it updates the dictionary of the second...

This is the deep cause of the failures in test_multiprocessing involving "managers" objects.

Also a 2.5 backport candidate.
This commit is contained in:
Amaury Forgeot d'Arc 2008-06-30 22:42:40 +00:00
parent 1d2ce45689
commit 1f40c8a8d7
3 changed files with 34 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Modules/threadmodule.c
View file

@ -293,7 +293,10 @@ _ldict(localobject *self)
}
}
else if (self->dict != ldict) {
/* The call to tp_init above may have caused another thread to run.
Install our ldict again. */
if (self->dict != ldict) {
Py_CLEAR(self->dict);
Py_INCREF(ldict);
self->dict = ldict;