mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-09 16:34:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 17

bpo-32137: The repr of deeply nested dict now raises a RecursionError (#4570)

Browse source 
instead of crashing due to a stack overflow.

This perhaps will fix similar problems in other extension types.
This commit is contained in:
Serhiy Storchaka 2017-12-03 22:12:11 +02:00 • committed by GitHub
parent eea3cc1ef0
commit 1fb72d2ad2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 26 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Lib/test/mapping_tests.py
View file

@ -1,6 +1,7 @@
# tests common to dict and UserDict
import unittest
import collections
import sys
class BasicTestMappingProtocol(unittest.TestCase):
@ -619,6 +620,14 @@ class TestHashMappingProtocol(TestMappingProtocol):
d = self._full_mapping({1: BadRepr()})
self.assertRaises(Exc, repr, d)
def test_repr_deep(self):
d = self._empty_mapping()
for i in range(sys.getrecursionlimit() + 100):
d0 = d
d = self._empty_mapping()
d[1] = d0
self.assertRaises(RecursionError, repr, d)
def test_eq(self):
self.assertEqual(self._empty_mapping(), self._empty_mapping())
self.assertEqual(self._full_mapping({1: 2}),