mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-25 04:34:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

[3.14] GH-141509: Fix warning about remaining subinterpreters (GH-141528) (GH-141566)

Browse source 
(cherry picked from commit fa245df4a0)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
This commit is contained in:
Sergey Miryanov 2025-11-15 23:56:52 +05:00 • committed by GitHub
parent 8a67e3c2b0
commit 21e43d5e83
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Lib/test/test_interpreters/test_api.py
View file

@ -431,6 +431,7 @@ class InterpreterObjectTests(TestBase):
exit()""" exit()"""
stdout, stderr = repl.communicate(script) stdout, stderr = repl.communicate(script)
self.assertIsNone(stderr) self.assertIsNone(stderr)
self.assertIn(b"Interpreter.close()", stdout)
self.assertNotIn(b"Traceback", stdout) self.assertNotIn(b"Traceback", stdout)

3
Misc/NEWS.d/next/Core_and_Builtins/2025-11-14-00-19-45.gh-issue-141528.VWdax1.rst Normal file
View file

@ -0,0 +1,3 @@
Suggest using :meth:`concurrent.interpreters.Interpreter.close` instead of the
private ``_interpreters.destroy`` function when warning about remaining subinterpreters.
Patch by Sergey Miryanov.

2
Python/pylifecycle.c
View file

@ -2517,7 +2517,7 @@ finalize_subinterpreters(void)
(void)PyErr_WarnEx( (void)PyErr_WarnEx(
PyExc_RuntimeWarning, PyExc_RuntimeWarning,
"remaining subinterpreters; " "remaining subinterpreters; "
"destroy them with _interpreters.destroy()", "close them with Interpreter.close()",
0); 0);
/* Swap out the current tstate, which we know must belong /* Swap out the current tstate, which we know must belong