mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 00:48:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Issue #21032. Fixed socket leak if HTTPConnection.getresponse() fails.

Browse source 
Original patch by Martin Panter.
This commit is contained in:
Serhiy Storchaka 2014-12-01 13:10:12 +02:00
commit 2205da43a6
3 changed files with 38 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Lib/http/client.py
View file

@ -1233,18 +1233,22 @@ class HTTPConnection:
else:
response = self.response_class(self.sock, method=self._method)
response.begin()
assert response.will_close != _UNKNOWN
self.__state = _CS_IDLE
try:
response.begin()
assert response.will_close != _UNKNOWN
self.__state = _CS_IDLE
if response.will_close:
# this effectively passes the connection to the response
self.close()
else:
# remember this, so we can tell when it is complete
self.__response = response
if response.will_close:
# this effectively passes the connection to the response
self.close()
else:
# remember this, so we can tell when it is complete
self.__response = response
return response
return response
except:
response.close()
raise
try:
import ssl