mirror of
https://github.com/python/cpython.git
synced 2025-08-03 16:39:00 +00:00
Issue #21119: asyncio now closes sockets on errors
Fix ResourceWarning: create_connection(), create_datagram_endpoint() and create_unix_server() methods of event loop now close the newly created socket on error.
This commit is contained in:
parent
b9b965f6dd
commit
223a624158
4 changed files with 50 additions and 0 deletions
|
@ -256,6 +256,24 @@ class SelectorEventLoopUnixSocketTests(unittest.TestCase):
|
|||
'A UNIX Domain Socket was expected'):
|
||||
self.loop.run_until_complete(coro)
|
||||
|
||||
@mock.patch('asyncio.unix_events.socket')
|
||||
def test_create_unix_server_bind_error(self, m_socket):
|
||||
# Ensure that the socket is closed on any bind error
|
||||
sock = mock.Mock()
|
||||
m_socket.socket.return_value = sock
|
||||
|
||||
sock.bind.side_effect = OSError
|
||||
coro = self.loop.create_unix_server(lambda: None, path="/test")
|
||||
with self.assertRaises(OSError):
|
||||
self.loop.run_until_complete(coro)
|
||||
self.assertTrue(sock.close.called)
|
||||
|
||||
sock.bind.side_effect = MemoryError
|
||||
coro = self.loop.create_unix_server(lambda: None, path="/test")
|
||||
with self.assertRaises(MemoryError):
|
||||
self.loop.run_until_complete(coro)
|
||||
self.assertTrue(sock.close.called)
|
||||
|
||||
def test_create_unix_connection_path_sock(self):
|
||||
coro = self.loop.create_unix_connection(
|
||||
lambda: None, '/dev/null', sock=object())
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue