mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-29 05:05:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Issue #11246: Fix PyUnicode_FromFormat("%V")

Browse source 
Decode the byte string from UTF-8 (with replace error handler) instead of
ISO-8859-1 (in strict mode). Patch written by Ray Allen.
This commit is contained in:
Victor Stinner 2011-03-01 22:46:52 +00:00
parent c613b6bce1
commit 2512a8b62e
3 changed files with 36 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

26
Objects/unicodeobject.c
View file

@ -759,7 +759,7 @@ PyUnicode_FromFormatV(const char *format, va_list vargs)
if (*f == '%') {
if (*(f+1)=='%')
continue;
if (*(f+1)=='S' || *(f+1)=='R' || *(f+1)=='A')
if (*(f+1)=='S' || *(f+1)=='R' || *(f+1)=='A' || *(f+1) == 'V')
++callcount;
while (Py_ISDIGIT((unsigned)*f))
width = (width*10) + *f++ - '0';
@ -879,12 +879,20 @@ PyUnicode_FromFormatV(const char *format, va_list vargs)
{
PyObject *obj = va_arg(count, PyObject *);
const char *str = va_arg(count, const char *);
PyObject *str_obj;
assert(obj || str);
assert(!obj || PyUnicode_Check(obj));
if (obj)
if (obj) {
n += PyUnicode_GET_SIZE(obj);
else
n += strlen(str);
*callresult++ = NULL;
}
else {
str_obj = PyUnicode_DecodeUTF8(str, strlen(str), "replace");
if (!str_obj)
goto fail;
n += PyUnicode_GET_SIZE(str_obj);
*callresult++ = str_obj;
}
break;
}
case 'S':
@ -1087,14 +1095,18 @@ PyUnicode_FromFormatV(const char *format, va_list vargs)
case 'V':
{
PyObject *obj = va_arg(vargs, PyObject *);
const char *str = va_arg(vargs, const char *);
va_arg(vargs, const char *);
if (obj) {
Py_ssize_t size = PyUnicode_GET_SIZE(obj);
Py_UNICODE_COPY(s, PyUnicode_AS_UNICODE(obj), size);
s += size;
} else {
appendstring(str);
Py_UNICODE_COPY(s, PyUnicode_AS_UNICODE(*callresult),
PyUnicode_GET_SIZE(*callresult));
s += PyUnicode_GET_SIZE(*callresult);
Py_DECREF(*callresult);
}
++callresult;
break;
}
case 'S':
@ -1151,7 +1163,7 @@ PyUnicode_FromFormatV(const char *format, va_list vargs)
if (callresults) {
PyObject **callresult2 = callresults;
while (callresult2 < callresult) {
Py_DECREF(*callresult2);
Py_XDECREF(*callresult2);
++callresult2;
}
PyObject_Free(callresults);