mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-07-29 06:05:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Bug #1588217: don't parse "= " as a soft line break in binascii's

Browse source 
a2b_qp() function, instead leave it in the string as quopri.decode()
does.
This commit is contained in:
Georg Brandl 2006-11-16 17:08:45 +00:00
parent 540821183b
commit 25aabf4cbb
3 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Lib/test/test_binascii.py
View file

@ -134,7 +134,7 @@ class BinASCIITest(unittest.TestCase):
pass pass
else: else:
self.fail("binascii.a2b_qp(**{1:1}) didn't raise TypeError") self.fail("binascii.a2b_qp(**{1:1}) didn't raise TypeError")
self.assertEqual(binascii.a2b_qp("= "), "") self.assertEqual(binascii.a2b_qp("= "), "= ")
self.assertEqual(binascii.a2b_qp("=="), "=") self.assertEqual(binascii.a2b_qp("=="), "=")
self.assertEqual(binascii.a2b_qp("=AX"), "=AX") self.assertEqual(binascii.a2b_qp("=AX"), "=AX")
self.assertRaises(TypeError, binascii.b2a_qp, foo="bar") self.assertRaises(TypeError, binascii.b2a_qp, foo="bar")

4
Misc/NEWS
View file

@ -219,6 +219,10 @@ Library
Extension Modules Extension Modules
----------------- -----------------
- Bug #1588217: don't parse "= " as a soft line break in binascii's
a2b_qp() function, instead leave it in the string as quopri.decode()
does.
- Bug #1567666: Emulate GetFileAttributesExA for Win95. - Bug #1567666: Emulate GetFileAttributesExA for Win95.
- Patch #1576166: Support os.utime for directories on Windows NT+. - Patch #1576166: Support os.utime for directories on Windows NT+.

3
Modules/binascii.c
View file

@ -1057,8 +1057,7 @@ binascii_a2b_qp(PyObject *self, PyObject *args, PyObject *kwargs)
in++; in++;
if (in >= datalen) break; if (in >= datalen) break;
/* Soft line breaks */ /* Soft line breaks */
if ((data[in] == '\n') || (data[in] == '\r') || if ((data[in] == '\n') || (data[in] == '\r')) {
(data[in] == ' ') || (data[in] == '\t')) {
if (data[in] != '\n') { if (data[in] != '\n') {
while (in < datalen && data[in] != '\n') in++; while (in < datalen && data[in] != '\n') in++;
} }