mirror of
https://github.com/python/cpython.git
synced 2025-08-30 05:35:08 +00:00
Fix the internals of our hash functions to used unsigned values during hash
computation as the overflow behavior of signed integers is undefined. In practice we require compiling everything with -fwrapv which forces overflow to be defined as twos compliment but this keeps the code cleaner for checkers or in the case where someone has compiled it without -fwrapv or their compiler's equivalent. Found by Clang trunk's Undefined Behavior Sanitizer (UBSan). Cleanup only - no functionality or hash values change.
This commit is contained in:
parent
90555d0f0d
commit
27cbcd6241
5 changed files with 14 additions and 14 deletions
|
@ -7686,7 +7686,7 @@ unicode_hash(PyUnicodeObject *self)
|
|||
{
|
||||
Py_ssize_t len;
|
||||
Py_UNICODE *p;
|
||||
Py_hash_t x;
|
||||
Py_uhash_t x; /* Unsigned for defined overflow behavior. */
|
||||
|
||||
#ifdef Py_DEBUG
|
||||
assert(_Py_HashSecret_Initialized);
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue