mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-07-15 23:35:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Plug a memory leak in Py_InitModule4(): when PyDict_SetItemString() failed,

Browse source 
the object being inserted was not being DECREFed.

This closes SF bug #444486.
This commit is contained in:
Fred Drake 2001-08-04 03:11:25 +00:00
parent 53765753c4
commit 289898cdbb
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Python/modsupport.c
View file

@ -60,14 +60,18 @@ Py_InitModule4(char *name, PyMethodDef *methods, char *doc,
v = PyCFunction_New(ml, passthrough);
if (v == NULL)
return NULL;
if (PyDict_SetItemString(d, ml->ml_name, v) != 0)
if (PyDict_SetItemString(d, ml->ml_name, v) != 0) {
Py_DECREF(v);
return NULL;
}
Py_DECREF(v);
}
if (doc != NULL) {
v = PyString_FromString(doc);
if (v == NULL || PyDict_SetItemString(d, "__doc__", v) != 0)
if (v == NULL || PyDict_SetItemString(d, "__doc__", v) != 0) {
Py_DECREF(v);
return NULL;
}
Py_DECREF(v);
}
return m;