mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 00:48:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

bpo-37267: Do not check for FILE_TYPE_CHAR in os.dup() on Windows (GH-14051)

Browse source 
On Windows, os.dup() no longer creates an inheritable fd when handling a
character file.
This commit is contained in:
Zackery Spytz 2019-06-17 01:17:14 -06:00 • committed by Victor Stinner
parent 66d47da86a
commit 28fca0c422
3 changed files with 16 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Lib/test/test_os.py
View file

@ -3382,6 +3382,15 @@ class FDInheritanceTests(unittest.TestCase):
self.addCleanup(os.close, fd2)
self.assertEqual(os.get_inheritable(fd2), False)
@unittest.skipUnless(sys.platform == 'win32', 'win32-specific test')
def test_dup_nul(self):
# os.dup() was creating inheritable fds for character files.
fd1 = os.open('NUL', os.O_RDONLY)
self.addCleanup(os.close, fd1)
fd2 = os.dup(fd1)
self.addCleanup(os.close, fd2)
self.assertFalse(os.get_inheritable(fd2))
@unittest.skipUnless(hasattr(os, 'dup2'), "need os.dup2()")
def test_dup2(self):
fd = os.open(__file__, os.O_RDONLY)