mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-22 17:55:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 15

bpo-37267: Do not check for FILE_TYPE_CHAR in os.dup() on Windows (GH-14051)

Browse source 
On Windows, os.dup() no longer creates an inheritable fd when handling a
character file.
This commit is contained in:
Zackery Spytz 2019-06-17 01:17:14 -06:00 • committed by Victor Stinner
parent 66d47da86a
commit 28fca0c422
3 changed files with 16 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Python/fileutils.c
View file

@ -1776,7 +1776,6 @@ _Py_dup(int fd)
{
#ifdef MS_WINDOWS
HANDLE handle;
DWORD ftype;
#endif
assert(PyGILState_Check());
@ -1790,9 +1789,6 @@ _Py_dup(int fd)
return -1;
}
/* get the file type, ignore the error if it failed */
ftype = GetFileType(handle);
Py_BEGIN_ALLOW_THREADS
_Py_BEGIN_SUPPRESS_IPH
fd = dup(fd);
@ -1803,14 +1799,11 @@ _Py_dup(int fd)
return -1;
}
/* Character files like console cannot be make non-inheritable */
if (ftype != FILE_TYPE_CHAR) {
if (_Py_set_inheritable(fd, 0, NULL) < 0) {
_Py_BEGIN_SUPPRESS_IPH
close(fd);
_Py_END_SUPPRESS_IPH
return -1;
}
if (_Py_set_inheritable(fd, 0, NULL) < 0) {
_Py_BEGIN_SUPPRESS_IPH
close(fd);
_Py_END_SUPPRESS_IPH
return -1;
}
#elif defined(HAVE_FCNTL_H) && defined(F_DUPFD_CLOEXEC)
Py_BEGIN_ALLOW_THREADS