mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 17:08:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

Remove binding of captured exceptions when not used to reduce the chances of creating cycles (GH-17246)

Browse source 
Capturing exceptions into names can lead to reference cycles though the __traceback__ attribute of the exceptions in some obscure cases that have been reported previously and fixed individually. As these variables are not used anyway, we can remove the binding to reduce the chances of creating reference cycles.

See for example GH-13135
This commit is contained in:
Pablo Galindo 2019-11-19 21:34:03 +00:00 • committed by GitHub
parent c6b20be85c
commit 293dd23477
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
28 changed files with 39 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Lib/poplib.py
View file

@ -385,7 +385,7 @@ class POP3:
for capline in rawcaps:
capnm, capargs = _parsecap(capline)
caps[capnm] = capargs
except error_proto as _err:
except error_proto:
raise error_proto('-ERR CAPA not supported by server')
return caps