mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 00:48:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Remove binding of captured exceptions when not used to reduce the chances of creating cycles (GH-17246)

Browse source 
Capturing exceptions into names can lead to reference cycles though the __traceback__ attribute of the exceptions in some obscure cases that have been reported previously and fixed individually. As these variables are not used anyway, we can remove the binding to reduce the chances of creating reference cycles.

See for example GH-13135
This commit is contained in:
Pablo Galindo 2019-11-19 21:34:03 +00:00 • committed by GitHub
parent c6b20be85c
commit 293dd23477
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
28 changed files with 39 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Lib/test/test_traceback.py
View file

@ -313,7 +313,7 @@ class TracebackFormatTests(unittest.TestCase):
with captured_output("stderr") as stderr_f:
try:
f()
except RecursionError as exc:
except RecursionError:
render_exc()
else:
self.fail("no recursion occurred")
@ -360,7 +360,7 @@ class TracebackFormatTests(unittest.TestCase):
with captured_output("stderr") as stderr_g:
try:
g()
except ValueError as exc:
except ValueError:
render_exc()
else:
self.fail("no value error was raised")
@ -396,7 +396,7 @@ class TracebackFormatTests(unittest.TestCase):
with captured_output("stderr") as stderr_h:
try:
h()
except ValueError as exc:
except ValueError:
render_exc()
else:
self.fail("no value error was raised")
@ -424,7 +424,7 @@ class TracebackFormatTests(unittest.TestCase):
with captured_output("stderr") as stderr_g:
try:
g(traceback._RECURSIVE_CUTOFF)
except ValueError as exc:
except ValueError:
render_exc()
else:
self.fail("no error raised")
@ -452,7 +452,7 @@ class TracebackFormatTests(unittest.TestCase):
with captured_output("stderr") as stderr_g:
try:
g(traceback._RECURSIVE_CUTOFF + 1)
except ValueError as exc:
except ValueError:
render_exc()
else:
self.fail("no error raised")