mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-10 00:43:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 18

gh-85283: Build _statistics extension with the limited C API (#116927)

Browse source 
Argument Clinic now inlines _PyArg_CheckPositional() for the limited
C API. The generated code should be as fast or even a little bit
faster.
This commit is contained in:
Victor Stinner 2024-03-17 18:59:02 +01:00 • committed by GitHub
parent 0634201f53
commit 2982bdb936
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 20 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Doc/whatsnew/3.13.rst
View file

@ -1482,7 +1482,8 @@ Build Changes
* The ``errno``, ``fcntl``, ``grp``, ``md5``, ``pwd``, ``resource``, * The ``errno``, ``fcntl``, ``grp``, ``md5``, ``pwd``, ``resource``,
``termios``, ``winsound``, ``termios``, ``winsound``,
``_ctypes_test``, ``_multiprocessing.posixshmem``, ``_scproxy``, ``_stat``, ``_ctypes_test``, ``_multiprocessing.posixshmem``, ``_scproxy``, ``_stat``,
``_testimportmultiple`` and ``_uuid`` C extensions are now built with the ``_statistics``, ``_testimportmultiple`` and ``_uuid``
C extensions are now built with the
:ref:`limited C API <limited-c-api>`. :ref:`limited C API <limited-c-api>`.
(Contributed by Victor Stinner in :gh:`85283`.) (Contributed by Victor Stinner in :gh:`85283`.)

2
Misc/NEWS.d/next/C API/2024-03-14-10-33-58.gh-issue-85283.LOgmdU.rst
View file

@ -1,2 +1,2 @@
The ``fcntl``, ``grp``, ``pwd`` and ``termios`` C extensions are now The ``fcntl``, ``grp``, ``pwd``, ``termios`` and ``_statistics`` C extensions are now
built with the :ref:`limited C API <limited-c-api>`. Patch by Victor Stinner. built with the :ref:`limited C API <limited-c-api>`. Patch by Victor Stinner.

7
Modules/_statisticsmodule.c
View file

@ -1,8 +1,9 @@
/* statistics accelerator C extension: _statistics module. */ /* statistics accelerator C extension: _statistics module. */
// clinic/_statisticsmodule.c.h uses internal pycore_modsupport.h API // Need limited C API version 3.12 for Py_MOD_PER_INTERPRETER_GIL_SUPPORTED
#ifndef Py_BUILD_CORE_BUILTIN #include "pyconfig.h" // Py_GIL_DISABLED
# define Py_BUILD_CORE_MODULE 1 #ifndef Py_GIL_DISABLED
# define Py_LIMITED_API 0x030c0000
#endif #endif
#include "Python.h" #include "Python.h"

45
Modules/clinic/_statisticsmodule.c.h generated
View file

@ -2,15 +2,13 @@
preserve preserve
[clinic start generated code]*/ [clinic start generated code]*/
#include "pycore_modsupport.h" // _PyArg_CheckPositional()
PyDoc_STRVAR(_statistics__normal_dist_inv_cdf__doc__, PyDoc_STRVAR(_statistics__normal_dist_inv_cdf__doc__,
"_normal_dist_inv_cdf($module, p, mu, sigma, /)\n" "_normal_dist_inv_cdf($module, p, mu, sigma, /)\n"
"--\n" "--\n"
"\n"); "\n");
#define _STATISTICS__NORMAL_DIST_INV_CDF_METHODDEF \ #define _STATISTICS__NORMAL_DIST_INV_CDF_METHODDEF \
{"_normal_dist_inv_cdf", _PyCFunction_CAST(_statistics__normal_dist_inv_cdf), METH_FASTCALL, _statistics__normal_dist_inv_cdf__doc__}, {"_normal_dist_inv_cdf", (PyCFunction)(void(*)(void))_statistics__normal_dist_inv_cdf, METH_FASTCALL, _statistics__normal_dist_inv_cdf__doc__},
static double static double
_statistics__normal_dist_inv_cdf_impl(PyObject *module, double p, double mu, _statistics__normal_dist_inv_cdf_impl(PyObject *module, double p, double mu,
@ -25,38 +23,21 @@ _statistics__normal_dist_inv_cdf(PyObject *module, PyObject *const *args, Py_ssi
double sigma; double sigma;
double _return_value; double _return_value;
if (!_PyArg_CheckPositional("_normal_dist_inv_cdf", nargs, 3, 3)) { if (nargs != 3) {
PyErr_Format(PyExc_TypeError, "_normal_dist_inv_cdf expected 3 arguments, got %zd", nargs);
goto exit; goto exit;
} }
if (PyFloat_CheckExact(args[0])) { p = PyFloat_AsDouble(args[0]);
p = PyFloat_AS_DOUBLE(args[0]); if (p == -1.0 && PyErr_Occurred()) {
goto exit;
} }
else mu = PyFloat_AsDouble(args[1]);
{ if (mu == -1.0 && PyErr_Occurred()) {
p = PyFloat_AsDouble(args[0]); goto exit;
if (p == -1.0 && PyErr_Occurred()) {
goto exit;
}
} }
if (PyFloat_CheckExact(args[1])) { sigma = PyFloat_AsDouble(args[2]);
mu = PyFloat_AS_DOUBLE(args[1]); if (sigma == -1.0 && PyErr_Occurred()) {
} goto exit;
else
{
mu = PyFloat_AsDouble(args[1]);
if (mu == -1.0 && PyErr_Occurred()) {
goto exit;
}
}
if (PyFloat_CheckExact(args[2])) {
sigma = PyFloat_AS_DOUBLE(args[2]);
}
else
{
sigma = PyFloat_AsDouble(args[2]);
if (sigma == -1.0 && PyErr_Occurred()) {
goto exit;
}
} }
_return_value = _statistics__normal_dist_inv_cdf_impl(module, p, mu, sigma); _return_value = _statistics__normal_dist_inv_cdf_impl(module, p, mu, sigma);
if ((_return_value == -1.0) && PyErr_Occurred()) { if ((_return_value == -1.0) && PyErr_Occurred()) {
@ -67,4 +48,4 @@ _statistics__normal_dist_inv_cdf(PyObject *module, PyObject *const *args, Py_ssi
exit: exit:
return return_value; return return_value;
} }
/*[clinic end generated code: output=e7cead17f9f3e19f input=a9049054013a1b77]*/ /*[clinic end generated code: output=0f0c849d51f16f1b input=a9049054013a1b77]*/