mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-31 05:58:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Add a comment explaining the st_symbols cache.

Browse source
This commit is contained in:
Jeremy Hylton 2001-12-10 00:53:18 +00:00
parent 5801a2d8e3
commit 2990640d8a
1 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Python/symtable.c
View file

@ -4,6 +4,20 @@
#include "graminit.h" #include "graminit.h"
#include "structmember.h" #include "structmember.h"
/* The compiler uses this function to load a PySymtableEntry object
for a code block. Each block is loaded twice, once during the
symbol table pass and once during the code gen pass. Entries
created during the first pass are cached for the second pass, using
the st_symbols dictionary.
The cache is keyed by st_nscopes. Each code block node in a
module's parse tree can be assigned a unique id based on the order
in which the nodes are visited by the compiler. This strategy
works so long as the symbol table and codegen passes visit the same
nodes in the same order.
*/
PyObject * PyObject *
PySymtableEntry_New(struct symtable *st, char *name, int type, int lineno) PySymtableEntry_New(struct symtable *st, char *name, int type, int lineno)
{ {
@ -14,7 +28,7 @@ PySymtableEntry_New(struct symtable *st, char *name, int type, int lineno)
if (k == NULL) if (k == NULL)
goto fail; goto fail;
v = PyDict_GetItem(st->st_symbols, k); v = PyDict_GetItem(st->st_symbols, k);
if (v) /* XXX could check that name, type, lineno match */ { if (v) {
Py_DECREF(k); Py_DECREF(k);
Py_INCREF(v); Py_INCREF(v);
return v; return v;