mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-25 12:44:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

gh-126991: Fix reference leak in loading pickle's opcode BUILD (GH-126990)

Browse source 
If PyObject_SetItem() fails in the `load_build()` function of _pickle.c, no DECREF for the `dict` variable.
This commit is contained in:
Justin Applegate 2024-11-19 11:00:35 -05:00 • committed by GitHub
parent c5c9286804
commit 29cbcbd73b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Modules/_pickle.c
View file

@ -6730,6 +6730,7 @@ load_build(PickleState *st, UnpicklerObject *self)
} }
if (PyObject_SetItem(dict, d_key, d_value) < 0) { if (PyObject_SetItem(dict, d_key, d_value) < 0) {
Py_DECREF(d_key); Py_DECREF(d_key);
Py_DECREF(dict);
goto error; goto error;
} }
Py_DECREF(d_key); Py_DECREF(d_key);