mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-12-15 21:44:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

bpo-33110: Catch errors raised when running add_done_callback on already completed futures (GH-13141)

Browse source 
Wrap the callback call within the `add_done_callback` function within concurrent.futures, in order to behave in an identical manner to callbacks added to a running future are triggered once it has completed.
This commit is contained in:
Sam Martin 2019-05-22 22:29:02 +01:00 • committed by Antoine Pitrou
parent d8a82e2897
commit 2a3a2ece50
3 changed files with 21 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Lib/concurrent/futures/_base.py
View file

@ -404,7 +404,10 @@ class Future(object):
if self._state not in [CANCELLED, CANCELLED_AND_NOTIFIED, FINISHED]:
self._done_callbacks.append(fn)
return
fn(self)
try:
fn(self)
except Exception:
LOGGER.exception('exception calling callback for %r', self)
def result(self, timeout=None):
"""Return the result of the call that the future represents.