mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-27 02:39:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

Issue #1717: add a DeprecationWarning in 3.x on type initialization

Browse source 
for types that implement tp_reserved (formerly tp_compare) but
not tp_richcompare.
This commit is contained in:
Mark Dickinson 2009-02-08 11:02:10 +00:00
parent 598c3a8ad1
commit 2a7d45b680
1 changed files with 15 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Objects/typeobject.c
View file

@ -3886,6 +3886,21 @@ PyType_Ready(PyTypeObject *type)
goto error; goto error;
} }
/* Warn for a type that implements tp_compare (now known as
tp_reserved) but not tp_richcompare. */
if (type->tp_reserved && !type->tp_richcompare) {
int error;
char msg[240];
PyOS_snprintf(msg, sizeof(msg),
"Type %.100s defines tp_reserved (formerly "
"tp_compare) but not tp_richcompare. "
"Comparisons may not behave as intended.",
type->tp_name);
error = PyErr_WarnEx(PyExc_DeprecationWarning, msg, 1);
if (error == -1)
goto error;
}
/* All done -- set the ready flag */ /* All done -- set the ready flag */
assert(type->tp_dict != NULL); assert(type->tp_dict != NULL);
type->tp_flags = type->tp_flags =