mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-27 13:45:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

gh-85160: Reduce memory usage of singledispatchmethod (#107706)

Browse source 
A small followup to #107148

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This commit is contained in:
Alex Waygood 2023-08-07 13:46:36 +01:00 • committed by GitHub
parent 33cb0b06ef
commit 2ac103c346
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Lib/functools.py
View file

@ -928,14 +928,14 @@ class singledispatchmethod:
""" """
def __init__(self, func): def __init__(self, func):
import weakref # see comment in singledispatch function
if not callable(func) and not hasattr(func, "__get__"): if not callable(func) and not hasattr(func, "__get__"):
raise TypeError(f"{func!r} is not callable or a descriptor") raise TypeError(f"{func!r} is not callable or a descriptor")
self.dispatcher = singledispatch(func) self.dispatcher = singledispatch(func)
self.func = func self.func = func
import weakref # see comment in singledispatch function
self._method_cache = weakref.WeakKeyDictionary() self._method_cache = weakref.WeakKeyDictionary()
self._all_weakrefable_instances = True
def register(self, cls, method=None): def register(self, cls, method=None):
"""generic_method.register(cls, func) -> func """generic_method.register(cls, func) -> func
@ -945,11 +945,11 @@ class singledispatchmethod:
return self.dispatcher.register(cls, func=method) return self.dispatcher.register(cls, func=method)
def __get__(self, obj, cls=None): def __get__(self, obj, cls=None):
if self._all_weakrefable_instances: if self._method_cache is not None:
try: try:
_method = self._method_cache[obj] _method = self._method_cache[obj]
except TypeError: except TypeError:
self._all_weakrefable_instances = False self._method_cache = None
except KeyError: except KeyError:
pass pass
else: else:
@ -963,7 +963,7 @@ class singledispatchmethod:
_method.register = self.register _method.register = self.register
update_wrapper(_method, self.func) update_wrapper(_method, self.func)
if self._all_weakrefable_instances: if self._method_cache is not None:
self._method_cache[obj] = _method self._method_cache[obj] = _method
return _method return _method