mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-03 16:39:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

gh-107913: Fix possible losses of OSError error codes (GH-107930)

Browse source 
Functions like PyErr_SetFromErrno() and SetFromWindowsErr() should be
called immediately after using the C API which sets errno or the Windows
error code.
This commit is contained in:
Serhiy Storchaka 2023-08-27 00:35:06 +03:00 • committed by GitHub
parent e407cea193
commit 2b15536fa9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
17 changed files with 129 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Modules/socketmodule.c
View file

@ -5398,8 +5398,8 @@ sock_initobj_impl(PySocketSockObject *self, int family, int type, int proto,
}
if (!SetHandleInformation((HANDLE)fd, HANDLE_FLAG_INHERIT, 0)) {
closesocket(fd);
PyErr_SetFromWindowsErr(0);
closesocket(fd);
return -1;
}
@ -5613,8 +5613,9 @@ socket_gethostname(PyObject *self, PyObject *unused)
name,
&size))
{
PyErr_SetFromWindowsErr(0);
PyMem_Free(name);
return PyErr_SetFromWindowsErr(0);
return NULL;
}
result = PyUnicode_FromWideChar(name, size);
@ -6212,8 +6213,8 @@ socket_dup(PyObject *self, PyObject *fdobj)
}
if (!SetHandleInformation((HANDLE)newfd, HANDLE_FLAG_INHERIT, 0)) {
closesocket(newfd);
PyErr_SetFromWindowsErr(0);
closesocket(newfd);
return NULL;
}
#else
@ -6660,11 +6661,12 @@ socket_inet_ntop(PyObject *self, PyObject *args)
/* inet_ntop guarantee NUL-termination of resulting string. */
retval = inet_ntop(af, packed_ip.buf, ip, sizeof(ip));
PyBuffer_Release(&packed_ip);
if (!retval) {
PyErr_SetFromErrno(PyExc_OSError);
PyBuffer_Release(&packed_ip);
return NULL;
} else {
PyBuffer_Release(&packed_ip);
return PyUnicode_FromString(retval);
}
}
@ -7003,8 +7005,8 @@ socket_if_nameindex(PyObject *self, PyObject *arg)
ni = if_nameindex();
if (ni == NULL) {
Py_DECREF(list);
PyErr_SetFromErrno(PyExc_OSError);
Py_DECREF(list);
return NULL;
}