mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-31 14:07:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

bpo-33034: Improve exception message when cast fails for {Parse,Split}Result.port (GH-6078)

Browse source
This commit is contained in:
Matt Eaton 2018-03-20 01:41:37 -05:00 • committed by Berker Peksag
parent 7389fd935c
commit 2cb4661707
3 changed files with 18 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Lib/test/test_urlparse.py
View file

@ -936,6 +936,16 @@ class UrlParseTestCase(unittest.TestCase):
self.assertEqual(p2.scheme, 'tel')
self.assertEqual(p2.path, '+31641044153')
def test_port_casting_failure_message(self):
message = "Port could not be cast to integer value as 'oracle'"
p1 = urllib.parse.urlparse('http://Server=sde; Service=sde:oracle')
with self.assertRaisesRegex(ValueError, message):
p1.port
p2 = urllib.parse.urlsplit('http://Server=sde; Service=sde:oracle')
with self.assertRaisesRegex(ValueError, message):
p2.port
def test_telurl_params(self):
p1 = urllib.parse.urlparse('tel:123-4;phone-context=+1-650-516')
self.assertEqual(p1.scheme, 'tel')