mirror of
https://github.com/python/cpython.git
synced 2025-07-30 14:44:10 +00:00
raise a clear TypeError when trying to register a non-class
This commit is contained in:
parent
17527bedad
commit
2deb5c758a
3 changed files with 9 additions and 1 deletions
|
@ -96,7 +96,7 @@ class ABCMeta(type):
|
|||
|
||||
def register(cls, subclass):
|
||||
"""Register a virtual subclass of an ABC."""
|
||||
if not isinstance(cls, type):
|
||||
if not isinstance(subclass, type):
|
||||
raise TypeError("Can only register classes")
|
||||
if issubclass(subclass, cls):
|
||||
return # Already a subclass
|
||||
|
|
|
@ -149,6 +149,12 @@ class TestABC(unittest.TestCase):
|
|||
self.assertRaises(RuntimeError, C.register, A) # cycles not allowed
|
||||
C.register(B) # ok
|
||||
|
||||
def test_register_non_class(self):
|
||||
class A(object):
|
||||
__metaclass__ = abc.ABCMeta
|
||||
self.assertRaisesRegexp(TypeError, "Can only register classes",
|
||||
A.register, 4)
|
||||
|
||||
def test_registration_transitiveness(self):
|
||||
class A:
|
||||
__metaclass__ = abc.ABCMeta
|
||||
|
|
|
@ -47,6 +47,8 @@ Core and Builtins
|
|||
Library
|
||||
-------
|
||||
|
||||
- Issue #7792: Registering non-classes to ABCs raised an obscure error.
|
||||
|
||||
- Removed the functions 'verify' and 'vereq' from Lib/test/test_support.py.
|
||||
|
||||
- Issue #7773: Fix an UnboundLocalError in platform.linux_distribution() when
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue