Issue #27243: Change PendingDeprecationWarning -> DeprecationWarning.

As it was agreed in the issue, __aiter__ returning an awaitable
should result in PendingDeprecationWarning in 3.5 and in
DeprecationWarning in 3.6.
This commit is contained in:
Yury Selivanov 2016-11-08 15:13:07 -05:00
parent 1c9bd1d8ec
commit 2edd8a1e2c
3 changed files with 15 additions and 10 deletions

View file

@ -1398,7 +1398,7 @@ class CoroutineTest(unittest.TestCase):
buffer = []
async def test1():
with self.assertWarnsRegex(PendingDeprecationWarning, "legacy"):
with self.assertWarnsRegex(DeprecationWarning, "legacy"):
async for i1, i2 in AsyncIter():
buffer.append(i1 + i2)
@ -1412,7 +1412,7 @@ class CoroutineTest(unittest.TestCase):
buffer = []
async def test2():
nonlocal buffer
with self.assertWarnsRegex(PendingDeprecationWarning, "legacy"):
with self.assertWarnsRegex(DeprecationWarning, "legacy"):
async for i in AsyncIter():
buffer.append(i[0])
if i[0] == 20:
@ -1431,7 +1431,7 @@ class CoroutineTest(unittest.TestCase):
buffer = []
async def test3():
nonlocal buffer
with self.assertWarnsRegex(PendingDeprecationWarning, "legacy"):
with self.assertWarnsRegex(DeprecationWarning, "legacy"):
async for i in AsyncIter():
if i[0] > 20:
continue
@ -1514,7 +1514,7 @@ class CoroutineTest(unittest.TestCase):
return 123
async def foo():
with self.assertWarnsRegex(PendingDeprecationWarning, "legacy"):
with self.assertWarnsRegex(DeprecationWarning, "legacy"):
async for i in I():
print('never going to happen')
@ -1623,7 +1623,7 @@ class CoroutineTest(unittest.TestCase):
1/0
async def foo():
nonlocal CNT
with self.assertWarnsRegex(PendingDeprecationWarning, "legacy"):
with self.assertWarnsRegex(DeprecationWarning, "legacy"):
async for i in AI():
CNT += 1
CNT += 10
@ -1650,7 +1650,7 @@ class CoroutineTest(unittest.TestCase):
self.assertEqual(CNT, 0)
def test_for_9(self):
# Test that PendingDeprecationWarning can safely be converted into
# Test that DeprecationWarning can safely be converted into
# an exception (__aiter__ should not have a chance to raise
# a ZeroDivisionError.)
class AI:
@ -1660,13 +1660,13 @@ class CoroutineTest(unittest.TestCase):
async for i in AI():
pass
with self.assertRaises(PendingDeprecationWarning):
with self.assertRaises(DeprecationWarning):
with warnings.catch_warnings():
warnings.simplefilter("error")
run_async(foo())
def test_for_10(self):
# Test that PendingDeprecationWarning can safely be converted into
# Test that DeprecationWarning can safely be converted into
# an exception.
class AI:
async def __aiter__(self):
@ -1675,7 +1675,7 @@ class CoroutineTest(unittest.TestCase):
async for i in AI():
pass
with self.assertRaises(PendingDeprecationWarning):
with self.assertRaises(DeprecationWarning):
with warnings.catch_warnings():
warnings.simplefilter("error")
run_async(foo())