(merge 3.2) Issue #12451: Open files in binary mode in some tests when the text

file is not needed.

Remove also an unused variable (blank) in test_threading.
This commit is contained in:
Victor Stinner 2011-06-30 18:21:39 +02:00
commit 2f655b73e4
5 changed files with 16 additions and 18 deletions

View file

@ -108,7 +108,7 @@ class MmapTests(unittest.TestCase):
# Check that the underlying file is truncated too
# (bug #728515)
f = open(TESTFN)
f = open(TESTFN, 'rb')
try:
f.seek(0, 2)
self.assertEqual(f.tell(), 512)
@ -308,7 +308,7 @@ class MmapTests(unittest.TestCase):
f.write(2**16 * b'a') # Arbitrary character
f.close()
f = open(TESTFN)
f = open(TESTFN, 'rb')
mf = mmap.mmap(f.fileno(), 2**16, access=mmap.ACCESS_READ)
mf.close()
mf.close()
@ -530,7 +530,7 @@ class MmapTests(unittest.TestCase):
self.assertEqual(m[0:3], b'foo')
# Check that the underlying file is truncated too
f = open(TESTFN)
f = open(TESTFN, 'rb')
f.seek(0, 2)
self.assertEqual(f.tell(), halfsize + 512)
f.close()